-
Notifications
You must be signed in to change notification settings - Fork 33
Refactor network attachments #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor network attachments #367
Conversation
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/47422c278fcf402eb5c077f5ef2dfd68 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 28m 24s |
|
recheck |
|
Tested this change locally, it seems to be working correctly. I will need someone to check the code anyways. Could I ask you @adrianfusco? |
In Tempest and Tobiko controllers there is a duplicate code regarding network attachments. To make it easier to maintain, let's put the code in one place.
2631d4f to
5962ece
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianfusco, kstrenkova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d2d59eb75f7440959d95b350000e8ea4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 15m 44s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3330dba0194c45c6bf3c5099a692701b ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 46m 20s |
In Tempest and Tobiko controllers there is a duplicate code regarding network attachments. To make it easier to maintain, let's put the code in one place.